Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore stack and cabal files from hasktags #1118

Merged
merged 1 commit into from
Feb 23, 2016
Merged

Ignore stack and cabal files from hasktags #1118

merged 1 commit into from
Feb 23, 2016

Conversation

sLite
Copy link
Contributor

@sLite sLite commented Jan 28, 2016

As discussed on IRC.

As the windows version didn't include a find not applied there, and i have no windows environment to test on.

@gracjan
Copy link
Contributor

gracjan commented Jan 29, 2016

Very close. Note that find has -prune option that would help a lot because it can stop find from entering unwanted directories and doing a lot of useless work:

find . 
    -type d \( bad_directories \) -prune
    -o
    -type f \\( -name '*.hs' -or -name '*.lhs' -or -name '*.hsc' \\) -not \\( -name '#*' -or -name '.*' \\)
    -print0

Please change to using -prune. For more inspiration rgrep elisp function has a lot of logic like that.

@gracjan
Copy link
Contributor

gracjan commented Feb 6, 2016

@sLite: Note also #964.

@sLite
Copy link
Contributor Author

sLite commented Feb 10, 2016

@gracjan had some time issues lately, but i will look into this by the end of the week.

But i'm afraid that my experience with EL isn't nearly enough to tackle #964

Putting that aside, is the allegedly decrease in coverage something i have to care about to get this PR merged? I don't see how changing the find commandline should change code coverage, but maybe i'm missing something :>

@gracjan
Copy link
Contributor

gracjan commented Feb 10, 2016

coverage is not a problem. coveralls seems to misreport this and that, we will fix the coverage reporting later. Right now this is just a hint not a rule.

@sLite
Copy link
Contributor Author

sLite commented Feb 23, 2016

I've changed the ignored directories to -prune and moved from ignoring ./dist/build to ignoring the ./dist as a whole.

Please tell me if you think that could cause any troubles.
I did this because sometimes (i'm not exactly sure when and why) stack or cabal also place .hs files in ./dist/production

gracjan added a commit that referenced this pull request Feb 23, 2016
Ignore stack and cabal files from hasktags
@gracjan gracjan merged commit 560859a into haskell:master Feb 23, 2016
@gracjan
Copy link
Contributor

gracjan commented Feb 23, 2016

This is good as it is.

@gracjan
Copy link
Contributor

gracjan commented Feb 23, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants